Use Boost::json in olp-cpp-sdk-authentication#1674
Merged
rustam-gamidov-here merged 2 commits intofeature_boost_jsonfrom Mar 3, 2026
Merged
Use Boost::json in olp-cpp-sdk-authentication#1674rustam-gamidov-here merged 2 commits intofeature_boost_jsonfrom
rustam-gamidov-here merged 2 commits intofeature_boost_jsonfrom
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## feature_boost_json #1674 +/- ##
=====================================================
Coverage ? 80.38%
=====================================================
Files ? 351
Lines ? 14018
Branches ? 1518
=====================================================
Hits ? 11267
Misses ? 2134
Partials ? 617 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
rustam-gamidov-here
force-pushed
the
rga/ocmam-443-boost-json-to-auth
branch
10 times, most recently
from
a3a9336 to
80cc913
Compare
rustam-gamidov-here
requested review from
andrey-kashcheev,
asopov-here,
khomenkd and
mykolamalik
andrey-kashcheev
previously approved these changes
Mar 2, 2026
Contributor
andrey-kashcheev
left a comment
andrey-kashcheev
left a comment
There was a problem hiding this comment.
Do we need to have JSON sources to be included here in auth as well? It's currently in core, but does it work with visibility=hidden?
rustam-gamidov-here
force-pushed
the
rga/ocmam-443-boost-json-to-auth
branch
from
80cc913 to
e362140
Compare
Collaborator
Author
Nice catch! Looks like it should be in all projects. Not sure how to verify on CI because in tests we are accessing not exposed classes. |
andrey-kashcheev
approved these changes
Mar 3, 2026
mykolamalik
approved these changes
Mar 3, 2026
Migrating from RapidJSON Relates-To: OCMAM-443 Signed-off-by: Rustam Gamidov <ext-rustam.gamidov@here.com>
Migrating from RapidJSON Relates-To: OCMAM-443 Signed-off-by: Rustam Gamidov <ext-rustam.gamidov@here.com>
rustam-gamidov-here
force-pushed
the
rga/ocmam-443-boost-json-to-auth
branch
from
e362140 to
787a8ee
Compare
rustam-gamidov-here
added a commit
that referenced
this pull request
Mar 30, 2026
Migrating from RapidJSON Relates-To: OCMAM-443 Signed-off-by: Rustam Gamidov <ext-rustam.gamidov@here.com>
rustam-gamidov-here
added a commit
that referenced
this pull request
Mar 31, 2026
Migrating from RapidJSON Relates-To: OCMAM-443 Signed-off-by: Rustam Gamidov <ext-rustam.gamidov@here.com>
rustam-gamidov-here
added a commit
that referenced
this pull request
Apr 1, 2026
Migrating from RapidJSON Relates-To: OCMAM-443 Signed-off-by: Rustam Gamidov <ext-rustam.gamidov@here.com>
rustam-gamidov-here
added a commit
that referenced
this pull request
Apr 14, 2026
* CI: Add build with OLP_SDK_NO_EXCEPTION=ON (#1661) To catch issues in this kind of build earlier Relates-To: OCMAM-442 Signed-off-by: Rustam Gamidov <ext-rustam.gamidov@here.com> * Integrate Boost.Json patching 1.82 for no exception (#1662) Patch boost::json 1.82 with BOOST_NO_EXCEPTIONS Is is solved in boost::json 1.83 but we preferred to stay at 1.82 Relates-To: OCMAM-442 Signed-off-by: Rustam Gamidov <ext-rustam.gamidov@here.com> * Refactor PartitionsSaxHandler to use boost::json (#1670) Previously it was based on rapidjson The tests are adjusted accordingly. Relates-To: OCMAM-448 Signed-off-by: Alexander Sopov <ext-alexander.sopov@here.com> Signed-off-by: Rustam Gamidov <ext-rustam.gamidov@here.com> * CI: build with hidden symbols using Clang (#1675) Good to be able to do this. No tests as not exposed classes are accessed in tests. Examples: export functions from libs to utilize in the common binary Make boost::json header only in the read lib Otherwise there are unresolved external symbols when built with visibility=hidden Relates-To: MINOR Signed-off-by: Rustam Gamidov <ext-rustam.gamidov@here.com> * Use Boost::json in olp-cpp-sdk-authentication (#1674) Migrating from RapidJSON Relates-To: OCMAM-443 Signed-off-by: Rustam Gamidov <ext-rustam.gamidov@here.com> * Build with OLP_SDK_NO_EXCEPTION=ON using clang (#1676) It appeared that Clang and GCC complains on different lines at least in case of Boost codebase Relates-To: MINOR Signed-off-by: Rustam Gamidov <ext-rustam.gamidov@here.com> * Boost includes to private section of auth lib (#1678) Migrating from RapidJSON Relates-To: OCMAM-443 Signed-off-by: Rustam Gamidov <ext-rustam.gamidov@here.com> * Use Boost::json in olp-cpp-sdk-dataservice-write (#1681) Migrating from RapidJSON Copy json implementation wrappers to write lib This allows to keep other libs untouched until fully migrated to the boost::json and remove write lib dependency from public json wrappers. Alternative solutions tried are: - add boost json wrappers to the same files in the core but to additional namespace - changes in core, json still exposed - move boost json wrappers from core to internal for the repository include location and add it to all DataSDK projects - huge change Relates-To: OCMAM-445 Signed-off-by: Rustam Gamidov <ext-rustam.gamidov@here.com> * Use Boost::json in olp-cpp-sdk-dataservice-read (#1684) Migrating from RapidJSON Copy json implementation wrappers to read lib This allows to keep other libs untouched until fully migrated to the boost::json and remove read lib dependency from public json wrappers. Alternative solutions tried are: - add boost json wrappers to the same files in the core but to additional namespace - changes in core, json still exposed - move boost json wrappers from core to internal for the repository include location and add it to all DataSDK projects - huge change Relates-To: OCMAM-444 Signed-off-by: Rustam Gamidov <ext-rustam.gamidov@here.com> * Use Boost::json in olp-cpp-sdk-core (#1685) Migrating from RapidJSON Json wrappers has been moved and not exposed anymore Use Boost::json in mock-server-client Use boost::json in HarCaptureAdapter Relates-To: OCMAM-446 Signed-off-by: Rustam Gamidov <ext-rustam.gamidov@here.com> * Exclude RapidJSON from build Migrating to boost::json Relates-To: OCMAM-447 Signed-off-by: Rustam Gamidov <ext-rustam.gamidov@here.com> * Skip clang no exception build Boost date_time has no 'no_exception' setup and clang is compiling that code even if it's not used. GCC is OK Relates-To: OCMAM-447 Signed-off-by: Rustam Gamidov <ext-rustam.gamidov@here.com> --------- Signed-off-by: Rustam Gamidov <ext-rustam.gamidov@here.com> Signed-off-by: Alexander Sopov <ext-alexander.sopov@here.com> Co-authored-by: asopov-here <ext-alexander.sopov@here.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrating from RapidJSON
Relates-To: OCMAM-443